Bug 17394 - large svn tree, mostly tests
Summary: large svn tree, mostly tests
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-16 10:28 PST by Siavash Safi
Modified: 2010-12-12 17:37 PST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Siavash Safi 2008-02-16 10:28:17 PST
Layout tests are really big and get in the way of tracking SVN for casual developers.
Comment 1 Ismail Donmez 2008-02-21 13:31:32 PST
Putting tests into another modules, maybe seperate modules for webpages & bugzilla too, would be nice for people who wants to test latest svn.
Comment 2 Alp Toker 2008-02-21 13:31:53 PST
The tests are large, which is the main issue.

The website and bugzilla html sources (project infrastructure) although not as large, have a lot of small files that slow down SVN stat/diff, so we should look into getting those out of the way too at the same time.

I have a feeling moving the sources into a subdirectory will make more sense than moving everything else out of the way, but I didn't investigate this fully yet.

Comment 3 Eric Seidel (no email) 2008-02-21 13:36:21 PST
My 2¢:

1.  It's possible to check out part of an SVN tree.  You can pull down WebCore and JavaScriptCore and WebKit and WebKitTools individually w/o getting any of the rest of the stuff.
2.  It's impossible to do any sort of web engine hacking w/o lots of really good tests.

I think the LayoutTests layout could be improved, possibly not to pull down all the results for all the platforms.  Perhaps someone could come up with a nice script in WebKitTools to do a partial checkout.  But I think that LayoutTests should remain part of the default checkout.
Comment 4 Alp Toker 2008-02-21 16:40:47 PST
(In reply to comment #3)
> My 2¢:
> 
> 1.  It's possible to check out part of an SVN tree.  You can pull down WebCore
> and JavaScriptCore and WebKit and WebKitTools individually w/o getting any of
> the rest of the stuff.

SVN doesn't deal with this situation. If you try using a partial checkout you'll see how svn up etc. break down rapidly because of the pathological layout.

There are two approaches for developers to track SVN without doing a full checkout:

1) A shell script that has built in replacements for svn up, svn diff etc. specifically for the WebKit project (ie. it checks out GNUmakefile.am, configure.ac etc. individually and hashes and updates them from SVN). This didn't work well when new sources were added at the root and was becoming a support headache.

2) Debian's filtered git repository [1]. This is also flaky and doesn't solve the problem fully and can't be used to dcommit. It also means we have to teach people how to use git who would otherwise never need it.

[1] http://git.debian.org/?p=pkg-webkit/upstream.git;a=shortlog;h=filtered

> 2.  It's impossible to do any sort of web engine hacking w/o lots of really
> good tests.

Not really relevant here. This bug is about making things easier for WebKit porters and users. People who use the tests will be able to check them out and use them the same as ever after improving SVN layout.

We depend on community contributions for things like documentation, testing on different architectures and platforms we don't have access to and clearly from the feedback, they're just giving up or using stale tarballs right now. This is becoming a major issue for projects experimenting with WebKit.

Comment 5 Eric Seidel (no email) 2010-12-12 17:37:30 PST
Closing this old bug.