WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
173606
[GTK] Move WebGtkExtensionManager and WebGtkInjectedBundleMain to glib API dir
https://bugs.webkit.org/show_bug.cgi?id=173606
Summary
[GTK] Move WebGtkExtensionManager and WebGtkInjectedBundleMain to glib API dir
Carlos Garcia Campos
Reported
2017-06-20 10:03:55 PDT
And renamed them to use WebKit prefix instead of WebGtk
Attachments
Patch
(9.11 KB, patch)
2017-06-20 10:06 PDT
,
Carlos Garcia Campos
zan
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2017-06-20 10:06:34 PDT
Created
attachment 313411
[details]
Patch
Build Bot
Comment 2
2017-06-20 10:09:42 PDT
Attachment 313411
[details]
did not pass style-queue: ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/glib/WebKitInjectedBundleMain.cpp:22: You should add a blank line after implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/glib/WebKitInjectedBundleMain.cpp:22: You should not add a blank line before implementation file's own header. [build/include_order] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 3
2017-06-21 00:49:34 PDT
Committed
r218628
: <
http://trac.webkit.org/changeset/218628
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug