Bug 173604 - Remove no-op calls to purge SQLite caches on memory pressure.
Summary: Remove no-op calls to purge SQLite caches on memory pressure.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2017-06-20 09:42 PDT by Andreas Kling
Modified: 2017-06-20 11:48 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.47 KB, patch)
2017-06-20 09:44 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2017-06-20 09:42:46 PDT 
Yeah, so _sqlite3_purgeEligiblePagerCacheMemory() does nothing, and hasn't for a long time.
Comment 1 Andreas Kling 2017-06-20 09:44:27 PDT 
Created attachment 313409 [details]
Patch
Comment 2 Chris Dumez 2017-06-20 11:11:03 PDT 
Comment on attachment 313409 [details]
Patch

r=me :|
Comment 3 Andreas Kling 2017-06-20 11:11:17 PDT 
(In reply to Chris Dumez from comment #2)
> Comment on attachment 313409 [details]
> Patch
> 
> r=me :|

Why the face.
Comment 4 WebKit Commit Bot 2017-06-20 11:48:03 PDT 
Comment on attachment 313409 [details]
Patch

Clearing flags on attachment: 313409

Committed r218604: <http://trac.webkit.org/changeset/218604>
Comment 5 WebKit Commit Bot 2017-06-20 11:48:05 PDT 
All reviewed patches have been landed.  Closing bug.