The following files: JSTests/wasm/function-tests/call-indirect-params.js JSTests/wasm/function-tests/call-indirect.js JSTests/wasm/js-api/call-indirect-results.js Were changed to empty files in https://trac.webkit.org/changeset/209771 They were testing call-indirect with the wrong semantics, before we implemented tables. That change implemented tables and therefore removed the erroneous tests. We have a few tests for call_indirect which already do the right thing: JSTests/wasm/function-tests/context-switch.js JSTests/wasm/function-tests/exceptions.js JSTests/wasm/function-tests/grow-memory-2.js JSTests/wasm/function-tests/stack-overflow.js JSTests/wasm/function-tests/table-basic-2.js JSTests/wasm/function-tests/table-basic.js JSTests/wasm/js-api/call-indirect.js JSTests/wasm/js-api/table.js JSTests/wasm/js-api/unique-signature.js JSTests/wasm/js-api/wrapper-function.js I also just imported the updated spec tests which, among other things, test call_indirect: core/br.wast core/br_table.wast core/call_indirect.wast core/func.wast core/func_ptrs.wast core/imports.wast core/left-to-right.wast core/linking.wast core/nop.wast core/return.wast core/typecheck.wast core/unreachable.wast So I think it's OK to just delete the tests which should just have been deleted back when tables were added.
<rdar://problem/32659199>
Created attachment 312915 [details] patch
Comment on attachment 312915 [details] patch Rejecting attachment 312915 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 312915, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: file JSTests/ChangeLog patch: **** Only garbage was found in the patch input. rm 'JSTests/wasm/function-tests/call-indirect-params.js' patch: **** Only garbage was found in the patch input. rm 'JSTests/wasm/function-tests/call-indirect.js' patch: **** Only garbage was found in the patch input. rm 'JSTests/wasm/js-api/call-indirect-results.js' Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Saam Barati']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3931114
Created attachment 312916 [details] patch
Comment on attachment 312916 [details] patch Rejecting attachment 312916 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 312916, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: from patch file(s). patching file JSTests/ChangeLog patch: **** Only garbage was found in the patch input. rm 'JSTests/wasm/function-tests/call-indirect-params.js' patch: **** Only garbage was found in the patch input. rm 'JSTests/wasm/function-tests/call-indirect.js' patch: **** Only garbage was found in the patch input. rm 'JSTests/wasm/js-api/call-indirect-results.js' Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3931125
Committed manually in https://trac.webkit.org/r218290