Bug 173115 – [iOS] LowPowerModeNotifier notifies client on non-main thread

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

LowPowerModeNotifier notifies client on non-main thread which clients do not expect and this is causing crashes.

[Chris Dumez]

<rdar://problem/32644703>

[Chris Dumez]

Created attachment 312348 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 312348 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312348&action=review

> Source/WebCore/platform/ios/LowPowerModeNotifierIOS.mm:64
> +    dispatch_async(dispatch_get_main_queue(), ^ {

Why don't we just use callOnMainThread??

[Chris Dumez]

Comment on attachment 312348 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312348&action=review

>> Source/WebCore/platform/ios/LowPowerModeNotifierIOS.mm:64
>> +    dispatch_async(dispatch_get_main_queue(), ^ {
> 
> Why don't we just use callOnMainThread??

We can but this is iOS specific code anyway.

[Chris Dumez]

Created attachment 312367 [details]
Patch

[Chris Dumez]

Created attachment 312369 [details]
Patch

[Ryosuke Niwa]

(In reply to Chris Dumez from comment #4)
> Comment on attachment 312348 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312348&action=review
> 
> >> Source/WebCore/platform/ios/LowPowerModeNotifierIOS.mm:64
> >> +    dispatch_async(dispatch_get_main_queue(), ^ {
> > 
> > Why don't we just use callOnMainThread??
> 
> We can but this is iOS specific code anyway.

Sure but I think using callOnMainThread here would make the code read better.

[WebKit Commit Bot]

Comment on attachment 312369 [details]
Patch

Clearing flags on attachment: 312369

Committed r217959: <http://trac.webkit.org/changeset/217959>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.