Bug 173108 - [WebRTC] enableMockMediaEndpoint() is only used for the OpenWebRTC backend.
Summary: [WebRTC] enableMockMediaEndpoint() is only used for the OpenWebRTC backend.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-08 10:49 PDT by Carlos Alberto Lopez Perez
Modified: 2017-06-08 15:36 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2017-06-08 11:04 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2017-06-08 10:49:35 PDT 
It seems enableMockMediaEndpoint() is only needed when using the OpenWebRTC backend (is not needed with libwebrtc).
Comment 1 Carlos Alberto Lopez Perez 2017-06-08 11:04:50 PDT 
Created attachment 312323 [details]
Patch

inital patch: lets test EWS
Comment 2 Adrian Perez 2017-06-08 12:58:46 PDT 
Comment on attachment 312323 [details]
Patch

Informally reviewed, and I'd say it's a r+
Comment 3 Carlos Alberto Lopez Perez 2017-06-08 15:24:35 PDT 
Comment on attachment 312323 [details]
Patch

All EWS are fine with this.. so asking for formal review now
Comment 4 Carlos Alberto Lopez Perez 2017-06-08 15:36:52 PDT 
Comment on attachment 312323 [details]
Patch

Clearing flags on attachment: 312323

Committed r217953: <http://trac.webkit.org/changeset/217953>
Comment 5 Carlos Alberto Lopez Perez 2017-06-08 15:36:56 PDT 
All reviewed patches have been landed.  Closing bug.