Bug 173069 - Web Inspector: Decrease vertical spacing of pseudo-class toggles
Summary: Web Inspector: Decrease vertical spacing of pseudo-class toggles
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-07 12:43 PDT by Devin Rousso
Modified: 2017-06-07 13:26 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2017-06-07 12:44 PDT, Devin Rousso 		mattbaker: review-
Details | Formatted Diff | Diff
[Image] After Patch is applied (18.68 KB, image/png)
2017-06-07 12:44 PDT, Devin Rousso 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-06-07 12:43:02 PDT 
There is a lot of unnecessary spacing around the checkboxes for the pseudo-classes in the styles sidebar.
Comment 1 Devin Rousso 2017-06-07 12:44:08 PDT 
Created attachment 312209 [details]
Patch
Comment 2 Devin Rousso 2017-06-07 12:44:37 PDT 
Created attachment 312210 [details]
[Image] After Patch is applied
Comment 3 Nikita Vasilyev 2017-06-07 13:07:52 PDT 
I'm not sure I agree. The extra spacing emphasizes that pseudo-class toggles are not related to the first CSS rule in the sidebar, the inline style rule.
Comment 4 Matt Baker 2017-06-07 13:26:12 PDT 
Comment on attachment 312209 [details]
Patch

r- for now, I think Nikita has a good point.

Also, the height of the pseudo class area (31px) is related to the height of the navigation bar above it (29px, the difference is probably borders). Is the new height arbitrary or does it correspond to something?

That said I think it would be a good idea to revisit the Styles sidebar in the future, but we should do that as part of a larger effort to streamline the UI.