Bug 173008 - [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
Summary: [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-06 10:41 PDT by Jer Noble
Modified: 2017-06-06 19:12 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.57 KB, patch)
2017-06-06 10:43 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (5.57 KB, patch)
2017-06-06 11:00 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2017-06-06 10:41:59 PDT 
[Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
Comment 1 Jer Noble 2017-06-06 10:43:42 PDT 
Created attachment 312087 [details]
Patch
Comment 2 Eric Carlson 2017-06-06 10:51:37 PDT 
Comment on attachment 312087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312087&action=review

> Source/WebKit/mac/WebView/WebPreferences.mm:3089
> +- (NSString *)mediaUserGestureInheritsFromDocument

"mediaUserGestureInheritsFromDocument" - copy/pasta?

> Source/WebKit/mac/WebView/WebPreferences.mm:3094
> +- (void)setMediaUserGestureInheritsFromDocument:(NSString *)value

"setMediaUserGestureInheritsFromDocument" - copy/pasta?
Comment 3 Jer Noble 2017-06-06 11:00:01 PDT 
Created attachment 312090 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2017-06-06 11:28:59 PDT 
Comment on attachment 312090 [details]
Patch for landing

Clearing flags on attachment: 312090

Committed r217845: <http://trac.webkit.org/changeset/217845>
Comment 5 WebKit Commit Bot 2017-06-06 11:29:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Jon Lee 2017-06-06 19:12:27 PDT 
rdar://problem/31483572