172537 – Move css-shapes-1 test suite to WPT

Bug 172537 - Move css-shapes-1 test suite to WPT

Summary: Move css-shapes-1 test suite to WPT

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Manuel Rego Casasnovas

URL:
Keywords:

Depends on:
Blocks:

Reported:	2017-05-24 01:03 PDT by Manuel Rego Casasnovas
Modified:	2017-05-31 02:23 PDT (History)
CC List:	5 users (show)

See Also:

Attachments
Patch (2.91 MB, patch) 2017-05-24 01:35 PDT, Manuel Rego Casasnovas	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.49 MB, application/zip) 2017-05-24 02:51 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.51 MB, application/zip) 2017-05-24 02:57 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (2.19 MB, application/zip) 2017-05-24 03:12 PDT, Build Bot	no flags	Details
Patch (2.91 MB, patch) 2017-05-24 03:17 PDT, Manuel Rego Casasnovas	no flags	Details \| Formatted Diff \| Diff
Rebased patch (2.91 MB, patch) 2017-05-31 00:46 PDT, Manuel Rego Casasnovas	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Manuel Rego Casasnovas 2017-05-24 01:03:22 PDT

Move css-shapes-1 test suite to WPT

Comment 1 Manuel Rego Casasnovas 2017-05-24 01:35:06 PDT

Created attachment 311111 [details]
Patch

Comment 2 Build Bot 2017-05-24 02:51:36 PDT

Comment on attachment 311111 [details]
Patch

Attachment 311111 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3805811

New failing tests:
imported/w3c/web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-018.html

Comment 3 Build Bot 2017-05-24 02:51:38 PDT

Created attachment 311112 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 4 Build Bot 2017-05-24 02:57:37 PDT

Comment on attachment 311111 [details]
Patch

Attachment 311111 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3805817

New failing tests:
imported/w3c/web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-018.html
fetch/closing-while-fetching-blob.html

Comment 5 Build Bot 2017-05-24 02:57:38 PDT

Created attachment 311113 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

Comment 6 Build Bot 2017-05-24 03:12:55 PDT

Comment on attachment 311111 [details]
Patch

Attachment 311111 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3805819

New failing tests:
imported/w3c/web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-018.html

Comment 7 Build Bot 2017-05-24 03:12:57 PDT

Created attachment 311114 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 8 Manuel Rego Casasnovas 2017-05-24 03:17:08 PDT

Created attachment 311115 [details]
Patch

Comment 9 Manuel Rego Casasnovas 2017-05-24 04:27:21 PDT

This will allow us to remove the old "csswg-test" folder. PTAL.

Comment 10 Manuel Rego Casasnovas 2017-05-30 12:26:27 PDT

@youennf, I know this is not really important or urgent, but please could you take a look? Thanks!

Comment 11 youenn fablet 2017-05-30 14:45:06 PDT

Comment on attachment 311115 [details]
Patch

r=me.
Is it just moving the files, or also refreshing them.
If it is just about moving, would you be able to refresh them as a follow-up?

Comment 12 Manuel Rego Casasnovas 2017-05-31 00:46:50 PDT

Created attachment 311577 [details]
Rebased patch

Comment 13 Manuel Rego Casasnovas 2017-05-31 00:54:19 PDT

(In reply to youenn fablet from comment #11)
> Comment on attachment 311115 [details]
> Patch
> 
> r=me.
> Is it just moving the files, or also refreshing them.
> If it is just about moving, would you be able to refresh them as a follow-up?

It's refreshing them too, I've added a comment on the ChangeLog to make it explicit.

Thanks for the review!

Comment 14 WebKit Commit Bot 2017-05-31 02:23:42 PDT

Comment on attachment 311577 [details]
Rebased patch

Clearing flags on attachment: 311577

Committed r217596: <http://trac.webkit.org/changeset/217596>

Comment 15 WebKit Commit Bot 2017-05-31 02:23:43 PDT

All reviewed patches have been landed.  Closing bug.