Bug 172436 – Respect image UTIs when writing to item providers when beginning data interaction on an image

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Wenson Hsieh]

<rdar://problem/31786569>

[Wenson Hsieh]

Created attachment 310836 [details]
Patch

[Build Bot]

Comment on attachment 310836 [details]
Patch

Attachment 310836 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3792488

New failing tests:
imported/w3c/web-platform-tests/media-source/mediasource-buffered.html

[Build Bot]

Created attachment 310837 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Wenson Hsieh]

Created attachment 311013 [details]
Patch

[Wenson Hsieh]

Created attachment 311055 [details]
Tweak ChangeLogs for renamed bug title.

[Beth Dakin]

Comment on attachment 311055 [details]
Tweak ChangeLogs for renamed bug title.

View in context: https://bugs.webkit.org/attachment.cgi?id=311055&action=review

> Source/WebCore/ChangeLog:15
> +        Additionally, plumb the estimated size of the image and the name of the image (as it appears in the source URL)

These changes should be in a separate patch, but I'll let it slide.

[Wenson Hsieh]

Comment on attachment 311055 [details]
Tweak ChangeLogs for renamed bug title.

View in context: https://bugs.webkit.org/attachment.cgi?id=311055&action=review

>> Source/WebCore/ChangeLog:15
>> +        Additionally, plumb the estimated size of the image and the name of the image (as it appears in the source URL)
> 
> These changes should be in a separate patch, but I'll let it slide.

This is a good point. The changes involved in fixing the GIF bug are really unrelated to the changes for plumbing suggestedName and the size across. The right thing to do is to split this out into two patches (it could also be three, with different patches for suggested name and size, but I think that might be a bit excessive since the suggested name and size are plumbed so closely together). I'll split out this patch.

[Wenson Hsieh]

Created attachment 311102 [details]
Remove suggestedName and estimatedDisplayedSize plumbing.

[WebKit Commit Bot]

Comment on attachment 311102 [details]
Remove suggestedName and estimatedDisplayedSize plumbing.

Clearing flags on attachment: 311102

Committed r217332: <http://trac.webkit.org/changeset/217332>