Bug 172255 - imported/w3c/web-platform-tests/html/browsers/windows/browsing-context.html is a flaky failure
Summary: imported/w3c/web-platform-tests/html/browsers/windows/browsing-context.html i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ms2ger (he/him; ⌚ UTC+1/+2)
URL:
Keywords: InRadar
: 172934 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-05-17 17:06 PDT by Matt Lewis
Modified: 2018-01-02 12:59 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.99 KB, patch)
2018-01-02 09:03 PST, Ms2ger (he/him; ⌚ UTC+1/+2)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2017-05-17 17:06:14 PDT
The test imported/w3c/web-platform-tests/html/browsers/windows/browsing-context.html is a flaky failure on both Wk1 and wk2 on Sierra Debug.

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fbrowsers%2Fwindows%2Fbrowsing-context.html

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r216991%20(1055)/results.html
https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/1055

diff:
--- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/windows/browsing-context-expected.txt
+++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/windows/browsing-context-actual.txt
@@ -2,5 +2,5 @@
 FAIL Check that browsing context has new, ready HTML document assert_equals: The document's encoding should be 'UTF-8'. expected "UTF-8" but got "windows-1252"
 PASS Check that new document nodes extant, empty 
 PASS Check the document properties corresponding to the creator browsing context 
-FAIL Check the history.length of the created browsing context assert_equals: The history.length should be 1. expected 1 but got 100
+FAIL Check the history.length of the created browsing context assert_equals: The history.length should be 1. expected 1 but got 90
 


I was able to reproduce the failure on Sierra Debug with:

run-webkit-tests imported/w3c/web-platform-tests/html/browsers/windows/browsing-context.html --iterations=100 --no-retry-failure --debug
Comment 1 Matt Lewis 2017-05-26 10:18:17 PDT
This test is actually flaky on all Mac WK1 platforms and only on Debug WK2 per the flakiness dashboard. Right now test is marked as failure on windows in the expectations. 
However the release wk1 have only recently started to fail intermittently as of 5/22/17.
Test was originally brought in with this revision:
https://trac.webkit.org/changeset/213882/webkit
Comment 2 Alexey Proskuryakov 2017-06-09 22:26:54 PDT
*** Bug 172934 has been marked as a duplicate of this bug. ***
Comment 3 Alexey Proskuryakov 2017-06-09 22:28:26 PDT
Looking at the flakiness dashboard, it's very flaky, and it's affecting CQ/EWS. Could you please add an expectation?
Comment 4 Matt Lewis 2017-06-12 09:02:06 PDT
Marked the test as flaky https://trac.webkit.org/changeset/218104/webkit/
Comment 5 Ms2ger (he/him; ⌚ UTC+1/+2) 2018-01-02 09:03:36 PST
Created attachment 330321 [details]
Patch
Comment 6 WebKit Commit Bot 2018-01-02 10:29:44 PST
Comment on attachment 330321 [details]
Patch

Clearing flags on attachment: 330321

Committed r226328: <https://trac.webkit.org/changeset/226328>
Comment 7 WebKit Commit Bot 2018-01-02 10:29:46 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-01-02 12:59:18 PST
<rdar://problem/36260889>