Bug 172145 - Captions and subtitles not showing up in picture-in-picture for MSE content.
Summary: Captions and subtitles not showing up in picture-in-picture for MSE content.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-15 16:53 PDT by Jeremy Jones
Modified: 2017-11-02 11:44 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.95 KB, patch)
2017-05-15 16:58 PDT, Jeremy Jones 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing. (6.94 KB, patch)
2017-05-16 14:35 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2017-05-15 16:53:06 PDT 
Captions and subtitles not showing up in picture-in-picture for MSE content.
Comment 1 Jeremy Jones 2017-05-15 16:53:48 PDT 
rdar://problem/28738340
Comment 2 Jeremy Jones 2017-05-15 16:58:03 PDT 
Created attachment 310188 [details]
Patch
Comment 3 Eric Carlson 2017-05-15 20:25:40 PDT 
Comment on attachment 310188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310188&action=review

> Source/WebCore/ChangeLog:11
> +        This movest the TextTrackRepresentation platfrom layer into the fullscreen container layer when going into

Nit: movest

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:938
> +    FloatRect videoFullscreenFrame = m_videoFullscreenLayerManager->videoFullscreenFrame();

Nit: auto

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:939
> +    CGRect videoRect = [m_sampleBufferDisplayLayer bounds];

Ditto

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:940
> +    CGRect textFrame = m_sampleBufferDisplayLayer ? videoRect : CGRectMake(0, 0, videoFullscreenFrame.width(), videoFullscreenFrame.height());

Ditto
Comment 4 Jeremy Jones 2017-05-16 14:34:58 PDT 
Comment on attachment 310188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310188&action=review

>> Source/WebCore/ChangeLog:11
>> +        This movest the TextTrackRepresentation platfrom layer into the fullscreen container layer when going into
> 
> Nit: movest

Fixed.

>> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:938
>> +    FloatRect videoFullscreenFrame = m_videoFullscreenLayerManager->videoFullscreenFrame();
> 
> Nit: auto

Done.

>> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:939
>> +    CGRect videoRect = [m_sampleBufferDisplayLayer bounds];
> 
> Ditto

Done.

>> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:940
>> +    CGRect textFrame = m_sampleBufferDisplayLayer ? videoRect : CGRectMake(0, 0, videoFullscreenFrame.width(), videoFullscreenFrame.height());
> 
> Ditto

Done.
Comment 5 Jeremy Jones 2017-05-16 14:35:39 PDT 
Created attachment 310298 [details]
Patch for landing.
Comment 6 WebKit Commit Bot 2017-05-16 15:27:16 PDT 
Comment on attachment 310298 [details]
Patch for landing.

Clearing flags on attachment: 310298

Committed r216951: <http://trac.webkit.org/changeset/216951>