Bug 172124 - REGRESSION(r216763): JetStream is 1% slower on Mac
Summary: REGRESSION(r216763): JetStream is 1% slower on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-15 09:40 PDT by Michael Saboff
Modified: 2017-05-16 17:12 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.31 KB, patch)
2017-05-16 16:05 PDT, Michael Saboff
fpizlo: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-03 for mac-elcapitan (1011.30 KB, application/zip)
2017-05-16 17:03 PDT, WebKit Commit Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2017-05-15 09:40:47 PDT
Change set r216763: <http://trac.webkit.org/changeset/216763> caused a 1% regression of JetStream on Mac.  There are only two small changes from that patch that should run on Mac.
1) The scavenger delay was reduced from 512ms to 250ms
2) The scavenger thread QOS was changed from QOS_CLASS_UNSPECIFIED to QOS_CLASS_USER_INITIATED.
Comment 1 Radar WebKit Bug Importer 2017-05-15 09:41:23 PDT
<rdar://problem/32199245>
Comment 2 Michael Saboff 2017-05-16 16:05:46 PDT
Created attachment 310313 [details]
Patch
Comment 3 WebKit Commit Bot 2017-05-16 16:50:39 PDT
The commit-queue encountered the following flaky tests while processing attachment 310313 [details]:

http/tests/misc/acid3.html bug 165734 (authors: abecsi@webkit.org, arv@chromium.org, cdumez@apple.com, rniwa@webkit.org, and tonyg@chromium.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2017-05-16 16:50:49 PDT
The commit-queue encountered the following flaky tests while processing attachment 310313 [details]:

http/tests/media/hls/video-controls-live-stream.html bug 172199 (authors: graouts@apple.com, mcatanzaro@igalia.com, and ryanhaddad@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2017-05-16 17:03:56 PDT
Comment on attachment 310313 [details]
Patch

Rejecting attachment 310313 [details] from commit-queue.

New failing tests:
http/tests/media/hls/video-duration-accessibility.html
Full output: http://webkit-queues.webkit.org/results/3753430
Comment 6 WebKit Commit Bot 2017-05-16 17:03:58 PDT
Created attachment 310321 [details]
Archive of layout-test-results from webkit-cq-03 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 7 Michael Saboff 2017-05-16 17:12:38 PDT
Committed r216960: <http://trac.webkit.org/changeset/216960>