WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
172024
[Readable Streams API] Add ReadableStreamBYOBReader closed getter
https://bugs.webkit.org/show_bug.cgi?id=172024
Summary
[Readable Streams API] Add ReadableStreamBYOBReader closed getter
Romain Bellessort
Reported
2017-05-12 01:25:52 PDT
Implement closed getter of ReadableStreamBYOBReader
Attachments
Patch
(12.32 KB, patch)
2017-05-12 01:35 PDT
,
Romain Bellessort
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Romain Bellessort
Comment 1
2017-05-12 01:35:27 PDT
Created
attachment 309883
[details]
Patch
youenn fablet
Comment 2
2017-05-12 12:15:19 PDT
Comment on
attachment 309883
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=309883&action=review
> LayoutTests/streams/readable-stream-byob-reader.js:126 > +
All these tests seem like good candidates for WPT. Shouldn't they be upstreamed?
> LayoutTests/streams/readable-stream-byob-reader.js:140 > + return reader.closed.then(
It would be cool if we could do a one liner like: return promise_resolves(test, undefined, reader.close)
WebKit Commit Bot
Comment 3
2017-05-12 12:18:03 PDT
Comment on
attachment 309883
[details]
Patch Clearing flags on attachment: 309883 Committed
r216775
: <
http://trac.webkit.org/changeset/216775
>
WebKit Commit Bot
Comment 4
2017-05-12 12:18:05 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug