Bug 171810 - Refactor ImageInputType::width() / height() for clarity
Summary: Refactor ImageInputType::width() / height() for clarity
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-08 09:57 PDT by Chris Dumez
Modified: 2017-05-08 11:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.92 KB, patch)
2017-05-08 10:07 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.92 KB, patch)
2017-05-08 10:10 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-05-08 09:57:45 PDT 
Refactor ImageInputType::width() / height() for clarity.
Comment 1 Chris Dumez 2017-05-08 10:07:01 PDT 
Created attachment 309370 [details]
Patch
Comment 2 Build Bot 2017-05-08 10:09:06 PDT 
Attachment 309370 [details] did not pass style-queue:


ERROR: Source/WebCore/html/ImageInputType.cpp:182:  Missing space before ( in if(  [whitespace/parens] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2017-05-08 10:10:10 PDT 
Created attachment 309372 [details]
Patch
Comment 4 WebKit Commit Bot 2017-05-08 11:28:27 PDT 
Comment on attachment 309372 [details]
Patch

Clearing flags on attachment: 309372

Committed r216439: <http://trac.webkit.org/changeset/216439>
Comment 5 WebKit Commit Bot 2017-05-08 11:28:28 PDT 
All reviewed patches have been landed.  Closing bug.