Unprefix unicode-bidi CSS values
Created attachment 309250 [details] Patch
Comment on attachment 309250 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309250&action=review > Source/WebCore/css/CSSProperties.json:3510 > + "isolate", > + "isolate-override", > + "plaintext", > { > "value": "-webkit-isolate", > "status": "experimental", Can you fix the JSON to be like: { "value": "isolate", "url": "https://www.w3.org/TR/css-writing-modes-3/#valdef-unicode-bidi-isolate" }, { "value": "-webkit-isolate", "status": "deprecated" }, etc? > Source/WebCore/css/parser/CSSParserFastPaths.cpp:659 > + || valueID == CSSValueBidiOverride || valueID == CSSValueIsolate > + || valueID == CSSValueIsolateOverride || valueID == CSSValuePlaintext > + || valueID == CSSValueWebkitIsolate || valueID == CSSValueWebkitIsolateOverride > + || valueID == CSSValueWebkitPlaintext; Could you group the prefixed and unprefixed in pairs please. > LayoutTests/ChangeLog:9 > + Import W3C's internationalization tests from > + https://www.w3.org/International/tests/repo/results/writing-modes-bidi I think these should go into LayoutTests/imported/
Created attachment 309287 [details] Patch
Comment on attachment 309287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309287&action=review > Source/WebCore/css/CSSProperties.json:3520 > "url": "https://www.w3.org/TR/css-writing-modes-3/#valdef-unicode-bidi-isolate" You can remove the URLs from the deprecated ones. > Source/WebCore/css/parser/CSSParserFastPaths.cpp:659 > + || valueID == CSSValueBidiOverride > + || valueID == CSSValueIsolate || valueID == CSSValueWebkitIsolate > + || valueID == CSSValueIsolateOverride || valueID == CSSValueWebkitIsolateOverride > + || valueID == CSSValuePlaintext || valueID == CSSValueWebkitPlaintext; So much better.
Comment on attachment 309287 [details] Patch Attachment 309287 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3688797 New failing tests: fast/css/unicode-bidi-computed-value.html fast/css/default-bidi-css-rules.html
Created attachment 309289 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 309287 [details] Patch Attachment 309287 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3688758 New failing tests: fast/css/unicode-bidi-computed-value.html fast/css/default-bidi-css-rules.html
Created attachment 309290 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 309287 [details] Patch Attachment 309287 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3688801 New failing tests: fast/css/unicode-bidi-computed-value.html fast/css/default-bidi-css-rules.html
Created attachment 309291 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 309287 [details] Patch Attachment 309287 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3688818 New failing tests: imported/w3c/i18n/bidi/block-plaintext-005.html fast/css/default-bidi-css-rules.html imported/w3c/i18n/bidi/bidi-plaintext-011.html fast/css/unicode-bidi-computed-value.html
Created attachment 309292 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 309345 [details] Patch for committing
Comment on attachment 309345 [details] Patch for committing Clearing flags on attachment: 309345 Committed r216418: <http://trac.webkit.org/changeset/216418>