Bug 171444 - Speedometer: Add a React.js TodoMVC implementation
Summary: Speedometer: Add a React.js TodoMVC implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Addy Osmani
URL:
Keywords:
Depends on:
Blocks: 170513
  Show dependency tree / graph
 
Reported: 2017-04-28 12:51 PDT by Addy Osmani
Modified: 2019-05-02 16:24 PDT (History)
6 users (show)

See Also:

Attachments
Patch (589.96 KB, patch)
2017-04-28 12:56 PDT, Addy Osmani 		no flags Details | Formatted Diff | Diff
Patch (427.14 KB, patch)
2017-05-11 23:46 PDT, Addy Osmani 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Addy Osmani 2017-04-28 12:51:38 PDT 
As part of Speedometer 2.0 (https://bugs.webkit.org/show_bug.cgi?id=170513), this brings an up to date React TodoMVC implementation to the benchmark.
Comment 1 Addy Osmani 2017-04-28 12:56:27 PDT 
Created attachment 308579 [details]
Patch
Comment 2 Addy Osmani 2017-04-28 16:35:36 PDT 
Note: we will want to also remove Speedometer/resources/todomvc/labs/architecture-examples/react (old version)
Comment 3 Ryosuke Niwa 2017-05-09 14:26:26 PDT 
Comment on attachment 308579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308579&action=review

> PerformanceTests/ChangeLog:7
> +        Speedometer: add React.js TodoMVC implementation

Again, we need a blank line before this.

> PerformanceTests/ChangeLog:10
> +        (app.Utils.uuid):

Also remove these inline comments.
Comment 4 Addy Osmani 2017-05-11 23:46:13 PDT 
Created attachment 309875 [details]
Patch
Comment 5 Addy Osmani 2017-05-11 23:46:52 PDT 
Added a blank line and removed extraneous comments from the changelog.
Comment 6 WebKit Commit Bot 2017-05-12 02:00:50 PDT 
Comment on attachment 309875 [details]
Patch

Clearing flags on attachment: 309875

Committed r216754: <http://trac.webkit.org/changeset/216754>
Comment 7 WebKit Commit Bot 2017-05-12 02:00:52 PDT 
All reviewed patches have been landed.  Closing bug.