Bug 171339 - Make user script injection more robust
Summary: Make user script injection more robust
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-26 13:19 PDT by Alex Christensen
Modified: 2017-04-28 00:27 PDT (History)
6 users (show)

See Also:

Attachments
Patch (11.49 KB, patch)
2017-04-26 13:33 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-04-26 13:19:57 PDT 
Make user script injection more robust
Comment 1 Alex Christensen 2017-04-26 13:33:42 PDT 
Created attachment 308280 [details]
Patch
Comment 2 Geoffrey Garen 2017-04-26 13:37:37 PDT 
Comment on attachment 308280 [details]
Patch

r=me
Comment 3 Alex Christensen 2017-04-26 14:11:12 PDT 
Comment on attachment 308280 [details]
Patch

I'm not sure this will fix anything because m_script can never be null and forEachUserScript does everything synchronously.
Comment 4 WebKit Commit Bot 2017-04-26 14:40:52 PDT 
Comment on attachment 308280 [details]
Patch

Clearing flags on attachment: 308280

Committed r215831: <http://trac.webkit.org/changeset/215831>
Comment 5 WebKit Commit Bot 2017-04-26 14:40:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 David Kilzer (:ddkilzer) 2017-04-28 00:27:26 PDT 
<rdar://problem/30643691>