Bug 171315 - [Color] Make gradients work with ExtendedColors
Summary: [Color] Make gradients work with ExtendedColors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-25 22:36 PDT by Dean Jackson
Modified: 2017-04-26 21:15 PDT (History)
4 users (show)

See Also:

Attachments
Patch (16.14 KB, patch)
2017-04-25 23:05 PDT, Dean Jackson 		graouts: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-elcapitan (1.94 MB, application/zip)
2017-04-26 00:18 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2017-04-25 22:36:01 PDT 
[Color] Make gradients work with ExtendedColors
Comment 1 Dean Jackson 2017-04-25 23:05:30 PDT 
Created attachment 308221 [details]
Patch
Comment 2 Dean Jackson 2017-04-25 23:07:19 PDT 
<rdar://problems/31830177>
Comment 3 Build Bot 2017-04-26 00:18:01 PDT 
Comment on attachment 308221 [details]
Patch

Attachment 308221 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3607911

New failing tests:
webrtc/datachannel/basic.html
Comment 4 Build Bot 2017-04-26 00:18:02 PDT 
Created attachment 308227 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Dean Jackson 2017-04-26 10:35:03 PDT 
Committed r215809: <http://trac.webkit.org/changeset/215809>
Comment 6 Darin Adler 2017-04-26 21:15:11 PDT 
Comment on attachment 308221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308221&action=review

> Source/WebCore/platform/graphics/Gradient.h:137
>          // FIXME: ExtendedColor - A color stop needs a notion of color space.

Can this FIXME be removed?