Bug 170960 - [mac-wk2] LayoutTest fast/mediastream/getUserMedia-webaudio.html is a flaky timeout
Summary: [mac-wk2] LayoutTest fast/mediastream/getUserMedia-webaudio.html is a flaky t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Lewis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-18 12:09 PDT by Ryan Haddad
Modified: 2021-04-19 14:10 PDT (History)
12 users (show)

See Also:


Attachments
Patch (1.33 KB, patch)
2017-05-01 15:06 PDT, Matt Lewis
no flags Details | Formatted Diff | Diff
Patch (1.31 KB, patch)
2017-05-01 15:27 PDT, Matt Lewis
no flags Details | Formatted Diff | Diff
Patch (2.19 KB, patch)
2021-04-19 09:39 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Matt Lewis 2017-05-01 15:06:56 PDT
Created attachment 308771 [details]
Patch
Comment 2 Ryan Haddad 2017-05-01 15:13:20 PDT
Comment on attachment 308771 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308771&action=review

> LayoutTests/platform/mac-wk2/TestExpectations:659
> +webkit.org/b/170960 fast/mediastream/getUserMedia-webaudio.html [ Pass Timeout ]

Add [ Sierra ] in front of the test name since this is only a flaky timeout there. Otherwise, this looks good.
Comment 3 Matt Lewis 2017-05-01 15:27:40 PDT
Created attachment 308776 [details]
Patch
Comment 4 Ryan Haddad 2017-05-01 15:29:29 PDT
Comment on attachment 308776 [details]
Patch

Clearing flags on attachment: 308776

Committed r216036: <http://trac.webkit.org/changeset/216036>
Comment 5 Ryan Haddad 2017-05-01 15:29:30 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryan Haddad 2017-05-01 15:29:51 PDT
(In reply to Ryan Haddad from comment #5)
> All reviewed patches have been landed.  Closing bug.

Reopening because this is just marking the test as flaky.
Comment 7 Matt Lewis 2017-05-18 15:15:04 PDT
El Capitan is now starting to timeout on the release build.

Unable to reproduce the issue locally.
Comment 8 Matt Lewis 2017-05-18 15:15:23 PDT
(In reply to Matt Lewis from comment #7)
> El Capitan is now starting to timeout on the release build.
> 
> Unable to reproduce the issue locally.

https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r217063%20(1646)/results.html
Comment 9 Amir Mark Jr 2021-02-15 13:20:42 PST
Issue is still occurring on Big Sur WK2 and Catalina WK2. 

https://results.webkit.org/?suite=layout-tests&test=fast%2Fmediastream%2FgetUserMedia-webaudio.html

Was able to reproduce locally using:

run-webkit-tests fast/mediastream/getUserMedia-webaudio.html --iterations 1000 -f
Comment 10 Robert Jenner 2021-03-30 19:22:08 PDT
Re-updated test expectations to include Failure here:
https://trac.webkit.org/changeset/275257/webkit
Comment 11 youenn fablet 2021-04-19 09:39:20 PDT
Created attachment 426436 [details]
Patch
Comment 12 youenn fablet 2021-04-19 09:39:40 PDT
<rdar://74158395>
Comment 13 EWS 2021-04-19 14:10:30 PDT
Committed r276273 (236755@main): <https://commits.webkit.org/236755@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426436 [details].