After change set r215072, ChakraCore/test/es6/ES6Function_bugs.js fails one subtest. That subtest however appears to be wrong. It checks that defineProperty("length") to a getter on a sealed function shouldn't throw. JSC and V8 both throw and that behavior seems to be consistent with the ECMAScript spec. That part of the test should be disabled.
Created attachment 306449 [details] Patch
Comment on attachment 306449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306449&action=review r=me > JSTests/ChakraCore/test/es6/ES6Function_bugs.js:32 > + * Verified that V8 also throws here. Can you file a bug on test262 for this?
(In reply to JF Bastien from comment #2) > Comment on attachment 306449 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=306449&action=review > > r=me > > > JSTests/ChakraCore/test/es6/ES6Function_bugs.js:32 > > + * Verified that V8 also throws here. > > Can you file a bug on test262 for this? This is Chakra's own test.
Comment on attachment 306449 [details] Patch Clearing flags on attachment: 306449 Committed r215133: <http://trac.webkit.org/changeset/215133>
All reviewed patches have been landed. Closing bug.