Bug 170484 - REGRESSION (r214586): LayoutTest swipe/main-frame-pinning-requirement.html is a flaky failure
Summary: REGRESSION (r214586): LayoutTest swipe/main-frame-pinning-requirement.html is...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Lewis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-04 16:28 PDT by Ryan Haddad
Modified: 2017-04-26 13:24 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.36 KB, patch)
2017-04-26 10:50 PDT, Matt Lewis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-04-04 16:28:17 PDT
LayoutTest swipe/main-frame-pinning-requirement.html is a flaky failure

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r214899%20(408)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=swipe%2Fmain-frame-pinning-requirement.html

--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/swipe/main-frame-pinning-requirement-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/swipe/main-frame-pinning-requirement-actual.txt
@@ -1,8 +1,8 @@
 startSwipeGesture
 completeSwipeGesture
 startSwipeGesture
+completeSwipeGesture
 didBeginSwipe
-completeSwipeGesture
 willEndSwipe
 didEndSwipe
 didRemoveSwipeSnapshot
Comment 1 Ryan Haddad 2017-04-04 16:28:58 PDT
I'm guessing this started after https://trac.webkit.org/changeset/214586/webkit
Comment 2 Tim Horton 2017-04-04 16:30:00 PDT
Noooooooooooooooooooooo
Comment 3 Matt Lewis 2017-04-26 10:50:31 PDT
Created attachment 308266 [details]
Patch
Comment 4 Alexey Proskuryakov 2017-04-26 12:41:01 PDT
Comment on attachment 308266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308266&action=review

> LayoutTests/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

If you remove this line, you can just ask for cq?, and no review.
Comment 5 WebKit Commit Bot 2017-04-26 13:09:45 PDT
Comment on attachment 308266 [details]
Patch

Clearing flags on attachment: 308266

Committed r215823: <http://trac.webkit.org/changeset/215823>
Comment 6 WebKit Commit Bot 2017-04-26 13:09:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Matt Lewis 2017-04-26 13:24:34 PDT
Reopening because my patch just marked the test as flaky.