Bug 170474 - Do some minor FEColorMatrix code cleanup and optimization
Summary: Do some minor FEColorMatrix code cleanup and optimization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-04 14:59 PDT by Simon Fraser (smfr)
Modified: 2017-04-04 17:23 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.81 KB, patch)
2017-04-04 16:30 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (8.80 KB, patch)
2017-04-04 16:31 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-04-04 14:59:07 PDT
Do some minor FEColorMatrix code cleanup and optimization
Comment 1 Simon Fraser (smfr) 2017-04-04 16:30:32 PDT
Created attachment 306228 [details]
Patch
Comment 2 Simon Fraser (smfr) 2017-04-04 16:31:34 PDT
Created attachment 306229 [details]
Patch
Comment 3 Build Bot 2017-04-04 16:33:34 PDT
Attachment 306229 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/filters/FEColorMatrix.cpp:83:  Extra space before [.  [whitespace/brackets] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2017-04-04 17:23:50 PDT
Comment on attachment 306229 [details]
Patch

Clearing flags on attachment: 306229

Committed r214916: <http://trac.webkit.org/changeset/214916>
Comment 5 WebKit Commit Bot 2017-04-04 17:23:52 PDT
All reviewed patches have been landed.  Closing bug.