RESOLVED FIXED 170193
Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions 
https://bugs.webkit.org/show_bug.cgi?id=170193
Summary Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions
Aakash Jain
Reported 2017-03-28 13:06:38 PDT
_presentPopoverForJavaScriptCoreTestRegressions dashboard test fails with error "undefined is not an object".
Attachments
Proposed patch (2.02 KB, patch)
2017-03-28 13:10 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Updated patch (2.02 KB, patch)
2017-03-28 13:12 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-03-28 13:10:04 PDT
Created attachment 305628 [details] Proposed patch
Aakash Jain
Comment 2 2017-03-28 13:12:53 PDT
Created attachment 305629 [details] Updated patch
Jason Marcell
Comment 3 2017-03-28 14:10:15 PDT
Confirmed that all tests are passing after applying 170191 & 170193.
WebKit Commit Bot
Comment 4 2017-03-28 14:56:30 PDT
Comment on attachment 305629 [details] Updated patch Rejecting attachment 305629 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 305629, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 214493 = b6cf2c6d60a2136c3c2f2518f65a3a1fe5de9953 r214494 = 2e3de94ceb111c23b31bcb4963d08d13a90f9339 r214495 = 99443ce429ff7bb437a4791d790c15bbdb1c7298 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/3429426
Aakash Jain
Comment 5 2017-03-28 15:15:41 PDT
Committed https://trac.webkit.org/changeset/214497/webkit
Note You need to log in before you can comment on or make changes to this bug.