Bug 170172 - [Win] Pass close_fds = True in Python popen call.
Summary: [Win] Pass close_fds = True in Python popen call.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: PlatformOnly
Depends on:
Blocks:
 
Reported: 2017-03-28 02:25 PDT by Per Arne Vollan
Modified: 2017-03-30 14:10 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.42 KB, patch)
2017-03-28 02:29 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-03-28 02:25:31 PDT
This was previously not supported on Windows, but in Python 2.7.10 it is.
Comment 1 Per Arne Vollan 2017-03-28 02:29:03 PDT
Created attachment 305580 [details]
Patch
Comment 2 Brent Fulgham 2017-03-30 09:30:38 PDT
Comment on attachment 305580 [details]
Patch

r=me.
Comment 3 Per Arne Vollan 2017-03-30 09:39:42 PDT
Comment on attachment 305580 [details]
Patch

Thanks for reviewing :)
Comment 4 WebKit Commit Bot 2017-03-30 14:10:57 PDT
Comment on attachment 305580 [details]
Patch

Clearing flags on attachment: 305580

Committed r214622: <http://trac.webkit.org/changeset/214622>
Comment 5 WebKit Commit Bot 2017-03-30 14:10:59 PDT
All reviewed patches have been landed.  Closing bug.