Bug 170080 - REGRESSION(r214195): zillow.com header video doesn't resume when switching to another tab and back
Summary: REGRESSION(r214195): zillow.com header video doesn't resume when switching to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2017-03-24 15:56 PDT by Andreas Kling
Modified: 2017-03-25 20:52 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.51 KB, patch)
2017-03-25 16:57 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2017-03-24 15:56:43 PDT
Repro steps:

1. open "zillow.com" in one tab
2. switch to another tab
3. switch back to the zillow tab

Notice how the huge video up top doesn't animate anymore.

This regressed with https://trac.webkit.org/changeset/214195/webkit
Comment 1 Radar WebKit Bug Importer 2017-03-24 16:02:56 PDT
<rdar://problem/31252522>
Comment 2 Chris Dumez 2017-03-25 10:21:12 PDT
We do call play() on the player when the view becomes visible again. Then I see the play / playing / timeupdate events getting fired. I also see rateDidChange() being called with a rate of 1. I do believe the video is actually playing now.

However, for some reason, the view stays static and does not display the frames.

If anyone has an idea of what could be going on, please let me know.
Comment 3 Chris Dumez 2017-03-25 16:03:38 PDT
(In reply to Chris Dumez from comment #2)
> We do call play() on the player when the view becomes visible again. Then I
> see the play / playing / timeupdate events getting fired. I also see
> rateDidChange() being called with a rate of 1. I do believe the video is
> actually playing now.
> 
> However, for some reason, the view stays static and does not display the
> frames.
> 
> If anyone has an idea of what could be going on, please let me know.

It looks like we are displaying the poster even though the video is playing again. If I update HTMLVideoElement::shouldDisplayPosterImage() to always return false, then the bug goes away.
Comment 4 Chris Dumez 2017-03-25 16:57:52 PDT
Created attachment 305408 [details]
Patch
Comment 5 WebKit Commit Bot 2017-03-25 20:52:44 PDT
Comment on attachment 305408 [details]
Patch

Clearing flags on attachment: 305408

Committed r214407: <http://trac.webkit.org/changeset/214407>
Comment 6 WebKit Commit Bot 2017-03-25 20:52:48 PDT
All reviewed patches have been landed.  Closing bug.