Bug 170080 – REGRESSION(r214195): zillow.com header video doesn't resume when switching to another tab and back

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Andreas Kling]

Repro steps:

1. open "zillow.com" in one tab
2. switch to another tab
3. switch back to the zillow tab

Notice how the huge video up top doesn't animate anymore.

This regressed with https://trac.webkit.org/changeset/214195/webkit

[Radar WebKit Bug Importer]

<rdar://problem/31252522>

[Chris Dumez]

We do call play() on the player when the view becomes visible again. Then I see the play / playing / timeupdate events getting fired. I also see rateDidChange() being called with a rate of 1. I do believe the video is actually playing now.

However, for some reason, the view stays static and does not display the frames.

If anyone has an idea of what could be going on, please let me know.

[Chris Dumez]

(In reply to Chris Dumez from comment #2)
> We do call play() on the player when the view becomes visible again. Then I
> see the play / playing / timeupdate events getting fired. I also see
> rateDidChange() being called with a rate of 1. I do believe the video is
> actually playing now.
> 
> However, for some reason, the view stays static and does not display the
> frames.
> 
> If anyone has an idea of what could be going on, please let me know.

It looks like we are displaying the poster even though the video is playing again. If I update HTMLVideoElement::shouldDisplayPosterImage() to always return false, then the bug goes away.

[Chris Dumez]

Created attachment 305408 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 305408 [details]
Patch

Clearing flags on attachment: 305408

Committed r214407: <http://trac.webkit.org/changeset/214407>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.