Bug 169912 - [ARM] Add missing MacroAssembler functions after r214187
Summary: [ARM] Add missing MacroAssembler functions after r214187
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Linux
: P1 Blocker
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 108645 169820
  Show dependency tree / graph
 
Reported: 2017-03-21 03:54 PDT by Csaba Osztrogonác
Modified: 2017-03-21 04:42 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.12 KB, patch)
2017-03-21 03:58 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2017-03-21 03:54:57 PDT 
https://trac.webkit.org/changeset/214187 broke the ARM build
because of unimplemented functions:
- storeFloat(FPRegisterID src, BaseIndex address)
- loadFloat(BaseIndex address, FPRegisterID dest)

It's super easy to fix the build, we already have these
functions for double type, it's a simple copy/paste patch.
Comment 1 Csaba Osztrogonác 2017-03-21 03:58:40 PDT 
Created attachment 304998 [details]
Patch
Comment 2 Yusuke Suzuki 2017-03-21 04:13:15 PDT 
Comment on attachment 304998 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2017-03-21 04:42:39 PDT 
Comment on attachment 304998 [details]
Patch

Clearing flags on attachment: 304998

Committed r214220: <http://trac.webkit.org/changeset/214220>
Comment 4 WebKit Commit Bot 2017-03-21 04:42:44 PDT 
All reviewed patches have been landed.  Closing bug.