Bug 169463 - [Win] Scrollbars buttons have incorrect size in HiDPI.
Summary: [Win] Scrollbars buttons have incorrect size in HiDPI.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
Keywords: InRadar
Depends on:
Reported: 2017-03-10 03:16 PST by Per Arne Vollan
Modified: 2017-03-10 12:25 PST (History)
4 users (show)

See Also:

Patch (2.63 KB, patch)
2017-03-10 03:20 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-03-10 03:16:41 PST
They are really small in HiDPI mode.
Comment 1 Per Arne Vollan 2017-03-10 03:20:43 PST
Created attachment 304037 [details]
Comment 2 Per Arne Vollan 2017-03-10 05:08:00 PST
Comment 3 Alex Christensen 2017-03-10 11:00:34 PST
Comment on attachment 304037 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=304037&action=review

I noticed this a while ago but didn't fix it yet.  Thanks for tracking this down.

> Source/WebCore/ChangeLog:9
> +        There seems to be a bug in DrawThemeBackground when the device context is scaled.
> +        We can work around this by scaling the drawing rectangle instead.

I'm not sure this is a bug in DrawThemeBackground.  I think we just need to scale the drawing rectangle or use something like https://msdn.microsoft.com/en-us/library/windows/desktop/dn384112.aspx in order to get correct behavior.
Comment 4 Per Arne Vollan 2017-03-10 11:56:11 PST
Comment on attachment 304037 [details]

Thanks for reviewing :)
Comment 5 WebKit Commit Bot 2017-03-10 12:25:44 PST
Comment on attachment 304037 [details]

Clearing flags on attachment: 304037

Committed r213727: <http://trac.webkit.org/changeset/213727>
Comment 6 WebKit Commit Bot 2017-03-10 12:25:47 PST
All reviewed patches have been landed.  Closing bug.