Bug 169013 - Replace -[WKWebView adjustedDataInteractionItemProviders:] with a UI delegate method
Summary: Replace -[WKWebView adjustedDataInteractionItemProviders:] with a UI delegate...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-28 17:57 PST by Wenson Hsieh
Modified: 2017-03-02 10:22 PST (History)
1 user (show)

See Also:

Attachments
Patch (10.27 KB, patch)
2017-02-28 18:21 PST, Wenson Hsieh 		mitz: review+
Details | Formatted Diff | Diff
Patch for landing (10.58 KB, patch)
2017-03-01 23:00 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-02-28 17:57:36 PST 
Replace -[WKWebView adjustedDataInteractionItemProviders:] with a UI delegate method
Comment 1 Wenson Hsieh 2017-02-28 18:21:05 PST 
Created attachment 303023 [details]
Patch
Comment 2 mitz 2017-03-01 22:43:42 PST 
Comment on attachment 303023 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303023&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:89
> +- (NSArray *)_webView:(WKWebView *)webView adjustedDataInteractionItemProviders:(NSArray *)originalItemProviders WK_API_AVAILABLE(ios(WK_IOS_TBA));

Can the return value and the second argument be a more specific, NSArray<…> *, type?
Comment 3 Wenson Hsieh 2017-03-01 23:00:33 PST 
Created attachment 303176 [details]
Patch for landing
Comment 4 Wenson Hsieh 2017-03-01 23:31:12 PST 
(In reply to comment #2)
> Comment on attachment 303023 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=303023&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:89
> > +- (NSArray *)_webView:(WKWebView *)webView adjustedDataInteractionItemProviders:(NSArray *)originalItemProviders WK_API_AVAILABLE(ios(WK_IOS_TBA));
> 
> Can the return value and the second argument be a more specific, NSArray<…>
> *, type?

Yes! Changed to NSArray<UIItemProvider *>*
Comment 5 WebKit Commit Bot 2017-03-01 23:42:38 PST 
Comment on attachment 303176 [details]
Patch for landing

Clearing flags on attachment: 303176

Committed r213272: <http://trac.webkit.org/changeset/213272>