WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
169013
Replace -[WKWebView adjustedDataInteractionItemProviders:] with a UI delegate method
https://bugs.webkit.org/show_bug.cgi?id=169013
Summary
Replace -[WKWebView adjustedDataInteractionItemProviders:] with a UI delegate...
Wenson Hsieh
Reported
2017-02-28 17:57:36 PST
Replace -[WKWebView adjustedDataInteractionItemProviders:] with a UI delegate method
Attachments
Patch
(10.27 KB, patch)
2017-02-28 18:21 PST
,
Wenson Hsieh
mitz: review+
Details
Formatted Diff
Diff
Patch for landing
(10.58 KB, patch)
2017-03-01 23:00 PST
,
Wenson Hsieh
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Wenson Hsieh
Comment 1
2017-02-28 18:21:05 PST
Created
attachment 303023
[details]
Patch
mitz
Comment 2
2017-03-01 22:43:42 PST
Comment on
attachment 303023
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=303023&action=review
> Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:89 > +- (NSArray *)_webView:(WKWebView *)webView adjustedDataInteractionItemProviders:(NSArray *)originalItemProviders WK_API_AVAILABLE(ios(WK_IOS_TBA));
Can the return value and the second argument be a more specific, NSArray<…> *, type?
Wenson Hsieh
Comment 3
2017-03-01 23:00:33 PST
Created
attachment 303176
[details]
Patch for landing
Wenson Hsieh
Comment 4
2017-03-01 23:31:12 PST
(In reply to
comment #2
)
> Comment on
attachment 303023
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=303023&action=review
> > > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:89 > > +- (NSArray *)_webView:(WKWebView *)webView adjustedDataInteractionItemProviders:(NSArray *)originalItemProviders WK_API_AVAILABLE(ios(WK_IOS_TBA)); > > Can the return value and the second argument be a more specific, NSArray<…> > *, type?
Yes! Changed to NSArray<UIItemProvider *>*
WebKit Commit Bot
Comment 5
2017-03-01 23:42:38 PST
Comment on
attachment 303176
[details]
Patch for landing Clearing flags on attachment: 303176 Committed
r213272
: <
http://trac.webkit.org/changeset/213272
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug