RESOLVED FIXED 168999
Web Inspector: RTL: expose the Layout Direction setting in Production builds, keep using LTR by default 
https://bugs.webkit.org/show_bug.cgi?id=168999
Summary Web Inspector: RTL: expose the Layout Direction setting in Production builds,...
Blaze Burg
Reported 2017-02-28 15:51:49 PST
We know of some major things that need work (Timeline tab and DataGrid), but the rest is probably ready for wider feedback.
Attachments
Patch (5.87 KB, patch)
2017-02-28 20:27 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-28 15:52:05 PST
<rdar://problem/30769594>
Devin Rousso
Comment 2 2017-02-28 18:11:24 PST
So do you mean exposing the setting, or allowing those with a RTL system language to use the RTL layout?
Blaze Burg
Comment 3 2017-02-28 19:21:44 PST
(In reply to comment #2) > So do you mean exposing the setting, or allowing those with a RTL system > language to use the RTL layout? This bug is to move the engineering-only Setting in Settings Tab to be always available. So someone could test it out with Safari Technology Preview but we won't show RTL to anyone unless they opt in to it by changing the setting themselves. When RTL support is far enough along, we'll just remove this and make it always inherit the system layout direction. I don't think it's quite there yet.
Devin Rousso
Comment 4 2017-02-28 20:27:47 PST
Created attachment 303031 [details] Patch
Blaze Burg
Comment 5 2017-02-28 20:56:24 PST
Comment on attachment 303031 [details] Patch r=me
WebKit Commit Bot
Comment 6 2017-02-28 21:31:25 PST
Comment on attachment 303031 [details] Patch Clearing flags on attachment: 303031 Committed r213205: <http://trac.webkit.org/changeset/213205>
WebKit Commit Bot
Comment 7 2017-02-28 21:31:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.