Bug 168954 - Remove _WKWebsiteDataRecord.h
Summary: Remove _WKWebsiteDataRecord.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-27 17:36 PST by Alexey Proskuryakov
Modified: 2017-02-27 20:49 PST (History)
3 users (show)

See Also:

Attachments
proposed patch (6.38 KB, patch)
2017-02-27 17:38 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2017-02-27 17:36:49 PST 
https://trac.webkit.org/changeset/182862 changed _WKWebsiteDataRecord to be a class with an interface but with no implementation, which doesn't work for TAPI.

Need to either add an implementation, or remove the header. Looks like it's never been used anywhere, so removing should be fine.
Comment 1 Alexey Proskuryakov 2017-02-27 17:38:48 PST 
Created attachment 302900 [details]
proposed patch
Comment 2 Aakash Jain 2017-02-27 17:42:08 PST 
unofficial r+, assuming ews bots are fine.
Comment 3 WebKit Commit Bot 2017-02-27 20:49:36 PST 
Comment on attachment 302900 [details]
proposed patch

Clearing flags on attachment: 302900

Committed r213118: <http://trac.webkit.org/changeset/213118>
Comment 4 WebKit Commit Bot 2017-02-27 20:49:40 PST 
All reviewed patches have been landed.  Closing bug.