Bug 168799 - [GTK] Layout test imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-api-texttracks.html is flaky
Summary: [GTK] Layout test imported/w3c/web-platform-tests/html/semantics/embedded-con...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-23 14:25 PST by Javier Fernandez
Modified: 2017-12-07 05:27 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.65 KB, patch)
2017-02-23 14:30 PST, Javier Fernandez
no flags Details | Formatted Diff | Diff
Patch (1.88 KB, patch)
2017-12-07 04:54 PST, Ms2ger (he/him; ⌚ UTC+1/+2)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2017-02-23 14:25:21 PST
Layout test imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-api-texttracks.html started to be flaky timing out and then passing in r198298, then started to fail as TEXT and then PASS in r199258. Updating expectations accordingly.
Comment 1 Javier Fernandez 2017-02-23 14:30:54 PST
Created attachment 302578 [details]
Patch
Comment 2 WebKit Commit Bot 2017-02-23 15:29:00 PST
The commit-queue encountered the following flaky tests while processing attachment 302578 [details]:

The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2017-02-23 17:30:00 PST
The commit-queue encountered the following flaky tests while processing attachment 302578 [details]:

The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2017-02-23 19:13:17 PST
Comment on attachment 302578 [details]
Patch

Clearing flags on attachment: 302578

Committed r212934: <http://trac.webkit.org/changeset/212934>
Comment 5 WebKit Commit Bot 2017-02-23 19:13:22 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Michael Catanzaro 2017-02-24 05:26:55 PST
Hey Javi, thanks for helping with the gardening! Please remember that the bugs in the TestExpectations file should refer to *open* bug reports. Could you please check your recent additions to the test expectations and make sure the bugs referenced there are open? Thanks!
Comment 7 Javier Fernandez 2017-02-24 06:08:00 PST
(In reply to comment #6)
> Hey Javi, thanks for helping with the gardening! Please remember that the
> bugs in the TestExpectations file should refer to *open* bug reports. Could
> you please check your recent additions to the test expectations and make
> sure the bugs referenced there are open? Thanks!

Hey Michael, yeah, I made a mistake this time only :) I forgot to apply the patch to a generic gardening bug, as I always do. 

I'm pretty sure the rest of my test expectations are still open.
Comment 8 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-12-07 04:54:56 PST
Created attachment 328691 [details]
Patch
Comment 9 WebKit Commit Bot 2017-12-07 05:27:56 PST
Comment on attachment 328691 [details]
Patch

Clearing flags on attachment: 328691

Committed r225625: <https://trac.webkit.org/changeset/225625>
Comment 10 WebKit Commit Bot 2017-12-07 05:27:58 PST
All reviewed patches have been landed.  Closing bug.