Bug 168796 - [WebRTC] RealtimeOutgoingAudioSource does not need to upsample audio buffers
Summary: [WebRTC] RealtimeOutgoingAudioSource does not need to upsample audio buffers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-23 13:09 PST by youenn fablet
Modified: 2017-02-23 15:07 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.79 KB, patch)
2017-02-23 13:12 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (4.74 KB, patch)
2017-02-23 14:23 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-02-23 13:09:51 PST 
libwebrtc will do it on its own if needed
Comment 1 youenn fablet 2017-02-23 13:12:10 PST 
Created attachment 302566 [details]
Patch
Comment 2 Jer Noble 2017-02-23 14:12:21 PST 
Comment on attachment 302566 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302566&action=review

> Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:40
> -static inline AudioStreamBasicDescription libwebrtcAudioFormat(size_t channelCount)
> +static inline AudioStreamBasicDescription libwebrtcAudioFormat(size_t sampleRate, size_t channelCount)

sampleRate should probably be a float (or a Float64).
Comment 3 youenn fablet 2017-02-23 14:23:33 PST 
Created attachment 302576 [details]
Patch for landing
Comment 4 youenn fablet 2017-02-23 14:24:09 PST 
Thanks for the review

(In reply to comment #2)
> Comment on attachment 302566 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302566&action=review
> 
> > Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:40
> > -static inline AudioStreamBasicDescription libwebrtcAudioFormat(size_t channelCount)
> > +static inline AudioStreamBasicDescription libwebrtcAudioFormat(size_t sampleRate, size_t channelCount)
> 
> sampleRate should probably be a float (or a Float64).

Done
Comment 5 WebKit Commit Bot 2017-02-23 15:07:33 PST 
Comment on attachment 302576 [details]
Patch for landing

Clearing flags on attachment: 302576

Committed r212928: <http://trac.webkit.org/changeset/212928>
Comment 6 WebKit Commit Bot 2017-02-23 15:07:37 PST 
All reviewed patches have been landed.  Closing bug.