Bug 168770 - [GTK] Compilation fails if using ninja together with icecream and cmake > 3.5
Summary: [GTK] Compilation fails if using ninja together with icecream and cmake > 3.5
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tomas Popela
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-23 03:15 PST by Tomas Popela
Modified: 2017-02-23 03:29 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.84 KB, patch)
2017-02-23 03:23 PST, Tomas Popela 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Popela 2017-02-23 03:15:54 PST 
Compilation fails if using ninja together with icecream and cmake > 3.5. It's because we turn on the response files support (because of bug 129771) in Source/cmake/OptionsCommon.cmake (by enabling CMAKE_NINJA_FORCE_RESPONSE_FILE), but the icecream compiler it not processing the response files correctly, and it's not passing compiler flags from the response files to the compiler (in our case it's -fPIC). The compilation succeeds with cmake <= 3.5, because the support for the ninja's response files was added in 3.6. For more information see the cmake bug https://gitlab.kitware.com/cmake/cmake/issues/16664 the issue was reported to icecream as well https://github.com/icecc/icecream/issues/188. In the meantime we should turn off the response files support if using cmake > 3.5 together with ninja generator and icecream.
Comment 1 Tomas Popela 2017-02-23 03:23:13 PST 
Created attachment 302502 [details]
Patch
Comment 2 Tomas Popela 2017-02-23 03:29:02 PST 
Comment on attachment 302502 [details]
Patch

Clearing flags on attachment: 302502

Committed r212882: <http://trac.webkit.org/changeset/212882>
Comment 3 Tomas Popela 2017-02-23 03:29:11 PST 
All reviewed patches have been landed.  Closing bug.