Bug 16861 - get rid of unnecessary string copying
Summary: get rid of unnecessary string copying
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-13 09:48 PST by Darin Adler
Modified: 2008-01-13 11:20 PST (History)
0 users

See Also:


Attachments
patch (13.47 KB, patch)
2008-01-13 09:58 PST, Darin Adler
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2008-01-13 09:48:03 PST
After StringImpl was made immutable, there are still some remaining callers that were making copies of strings for no reason. The only valid reason nowadays is thread safety.
Comment 1 Darin Adler 2008-01-13 09:58:19 PST
Created attachment 18423 [details]
patch
Comment 2 Eric Seidel (no email) 2008-01-13 11:07:42 PST
Comment on attachment 18423 [details]
patch

r=me
Comment 3 Darin Adler 2008-01-13 11:20:11 PST
Committed revision 29452.