Bug 168541 - Resource Load Statistics: Only scan website data store once per session ID + reinstate removal counting
Summary: Resource Load Statistics: Only scan website data store once per session ID + ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-17 17:16 PST by John Wilander
Modified: 2017-02-21 14:57 PST (History)
3 users (show)

See Also:

Attachments
Patch (11.49 KB, patch)
2017-02-17 17:25 PST, John Wilander 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2017-02-17 17:16:06 PST 
As of https://bugs.webkit.org/show_bug.cgi?id=167474 we iterate over all pages' WebsiteDataStores. Since pages share data stores we should make sure to only scan a WebsiteDataStore with a specific session ID once.

https://bugs.webkit.org/show_bug.cgi?id=167474 also explicitly regressed data record removal counting. We should add it back in.
Comment 1 John Wilander 2017-02-17 17:25:06 PST 
Created attachment 302020 [details]
Patch
Comment 2 John Wilander 2017-02-17 17:26:38 PST 
Andy, this is small a follow-up patch to https://bugs.webkit.org/show_bug.cgi?id=167474 which you reviewed.
Comment 3 John Wilander 2017-02-21 14:31:03 PST 
Comment on attachment 302020 [details]
Patch

Thanks, Alex!
Comment 4 WebKit Commit Bot 2017-02-21 14:57:13 PST 
Comment on attachment 302020 [details]
Patch

Clearing flags on attachment: 302020

Committed r212766: <http://trac.webkit.org/changeset/212766>
Comment 5 WebKit Commit Bot 2017-02-21 14:57:16 PST 
All reviewed patches have been landed.  Closing bug.