Bug 168496 - Fix tools that were broken by Efl removal
Summary: Fix tools that were broken by Efl removal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-16 22:26 PST by Alexey Proskuryakov
Modified: 2017-02-17 09:11 PST (History)
5 users (show)

See Also:


Attachments
proposed fix (2.42 KB, patch)
2017-02-16 22:29 PST, Alexey Proskuryakov
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (671.77 KB, application/zip)
2017-02-17 04:06 PST, Build Bot
no flags Details
Updated patch (4.46 KB, patch)
2017-02-17 07:12 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2017-02-16 22:26:45 PST
Some urgent fixes:
- broken flakiness dashboard;
- tasks keep being posted to Efl EWS.

A lot more things need to be removed in tools.
Comment 1 Alexey Proskuryakov 2017-02-16 22:29:55 PST
Created attachment 301884 [details]
proposed fix

AppScale apps will need to be updated after this lands.
Comment 2 Aakash Jain 2017-02-16 22:40:26 PST
I will update appscale apps after landing.


Do we need to remove EFL from TestResultServer/static-dashboards/flakiness_dashboard.js
Comment 3 Alexey Proskuryakov 2017-02-16 23:10:08 PST
Not sure, there are a lot of references in unit tests that may need to be fixed then. I don't think that we need to remove that in order to unbreak things.
Comment 4 Build Bot 2017-02-17 04:06:54 PST
Comment on attachment 301884 [details]
proposed fix

Attachment 301884 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3141981

New failing tests:
compositing/absolute-inside-out-of-view-fixed.html
Comment 5 Build Bot 2017-02-17 04:06:56 PST
Created attachment 301910 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 6 Aakash Jain 2017-02-17 07:12:39 PST
Created attachment 301928 [details]
Updated patch

actually we do need to update flakiness_dashboard.js, I tried and flakiness dashboard doesn't work without removing efl from flakiness_dashboard.js
Updated patch.

It works (already updated appscale apps) :)
Comment 7 Alexey Proskuryakov 2017-02-17 08:46:11 PST
Comment on attachment 301928 [details]
Updated patch

Yeah, it makes sense when looking at it again.
Comment 8 WebKit Commit Bot 2017-02-17 09:11:33 PST
Comment on attachment 301928 [details]
Updated patch

Clearing flags on attachment: 301928

Committed r212552: <http://trac.webkit.org/changeset/212552>
Comment 9 WebKit Commit Bot 2017-02-17 09:11:37 PST
All reviewed patches have been landed.  Closing bug.