Bug 168496 – Fix tools that were broken by Efl removal

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Alexey Proskuryakov]

Some urgent fixes:
- broken flakiness dashboard;
- tasks keep being posted to Efl EWS.

A lot more things need to be removed in tools.

[Alexey Proskuryakov]

Created attachment 301884 [details]
proposed fix

AppScale apps will need to be updated after this lands.

[Aakash Jain]

I will update appscale apps after landing.


Do we need to remove EFL from TestResultServer/static-dashboards/flakiness_dashboard.js

[Alexey Proskuryakov]

Not sure, there are a lot of references in unit tests that may need to be fixed then. I don't think that we need to remove that in order to unbreak things.

[Build Bot]

Comment on attachment 301884 [details]
proposed fix

Attachment 301884 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3141981

New failing tests:
compositing/absolute-inside-out-of-view-fixed.html

[Build Bot]

Created attachment 301910 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Aakash Jain]

Created attachment 301928 [details]
Updated patch

actually we do need to update flakiness_dashboard.js, I tried and flakiness dashboard doesn't work without removing efl from flakiness_dashboard.js
Updated patch.

It works (already updated appscale apps) :)

[Alexey Proskuryakov]

Comment on attachment 301928 [details]
Updated patch

Yeah, it makes sense when looking at it again.

[WebKit Commit Bot]

Comment on attachment 301928 [details]
Updated patch

Clearing flags on attachment: 301928

Committed r212552: <http://trac.webkit.org/changeset/212552>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.