Bug 168495 - Allow PlatformCALayers to specify that they want deep color backing store
Summary: Allow PlatformCALayers to specify that they want deep color backing store
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-16 21:20 PST by Simon Fraser (smfr)
Modified: 2017-03-16 16:57 PDT (History)
3 users (show)

See Also:

Attachments
Patch (40.38 KB, patch)
2017-02-16 21:26 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (40.47 KB, patch)
2017-02-16 21:35 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (41.22 KB, patch)
2017-02-17 10:48 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (41.35 KB, patch)
2017-02-17 10:59 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (42.37 KB, patch)
2017-02-17 11:44 PST, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-02-16 21:20:21 PST 
Allow PlatformCALayers to specify that they want deep color backing store
Comment 1 Simon Fraser (smfr) 2017-02-16 21:26:07 PST 
Created attachment 301880 [details]
Patch
Comment 2 Simon Fraser (smfr) 2017-02-16 21:35:05 PST 
Created attachment 301881 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-02-17 10:48:32 PST 
Created attachment 301955 [details]
Patch
Comment 4 Simon Fraser (smfr) 2017-02-17 10:59:22 PST 
Created attachment 301959 [details]
Patch
Comment 5 Simon Fraser (smfr) 2017-02-17 11:44:27 PST 
Created attachment 301965 [details]
Patch
Comment 6 Tim Horton 2017-02-17 12:08:11 PST 
Comment on attachment 301965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301965&action=review

> Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:977
> +#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 90300) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200)

Do we still need to build for 9.3?

> Source/WebCore/platform/graphics/ca/cocoa/WebTiledBackingLayer.h:47
> +- (void)setWantsDeepColorBackingStore:(BOOL)wantsDeepColor;
> +- (BOOL)wantsDeepColorBackingStore;

@property?

> LayoutTests/tiled-drawing/ios/iphone7/compositing-layers-deep-color.html:31
> +            if (window.internals) {

No need for these curly braces.
Comment 7 Simon Fraser (smfr) 2017-03-16 16:57:37 PDT 
https://trac.webkit.org/changeset/212590