WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
168495
Allow PlatformCALayers to specify that they want deep color backing store
https://bugs.webkit.org/show_bug.cgi?id=168495
Summary
Allow PlatformCALayers to specify that they want deep color backing store
Simon Fraser (smfr)
Reported
2017-02-16 21:20:21 PST
Allow PlatformCALayers to specify that they want deep color backing store
Attachments
Patch
(40.38 KB, patch)
2017-02-16 21:26 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(40.47 KB, patch)
2017-02-16 21:35 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(41.22 KB, patch)
2017-02-17 10:48 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(41.35 KB, patch)
2017-02-17 10:59 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(42.37 KB, patch)
2017-02-17 11:44 PST
,
Simon Fraser (smfr)
thorton
: review+
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2017-02-16 21:26:07 PST
Created
attachment 301880
[details]
Patch
Simon Fraser (smfr)
Comment 2
2017-02-16 21:35:05 PST
Created
attachment 301881
[details]
Patch
Simon Fraser (smfr)
Comment 3
2017-02-17 10:48:32 PST
Created
attachment 301955
[details]
Patch
Simon Fraser (smfr)
Comment 4
2017-02-17 10:59:22 PST
Created
attachment 301959
[details]
Patch
Simon Fraser (smfr)
Comment 5
2017-02-17 11:44:27 PST
Created
attachment 301965
[details]
Patch
Tim Horton
Comment 6
2017-02-17 12:08:11 PST
Comment on
attachment 301965
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=301965&action=review
> Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:977 > +#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 90300) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200)
Do we still need to build for 9.3?
> Source/WebCore/platform/graphics/ca/cocoa/WebTiledBackingLayer.h:47 > +- (void)setWantsDeepColorBackingStore:(BOOL)wantsDeepColor; > +- (BOOL)wantsDeepColorBackingStore;
@property?
> LayoutTests/tiled-drawing/ios/iphone7/compositing-layers-deep-color.html:31 > + if (window.internals) {
No need for these curly braces.
Simon Fraser (smfr)
Comment 7
2017-03-16 16:57:37 PDT
https://trac.webkit.org/changeset/212590
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug