Bug 168398 - Fix ASAN build after r212401
Summary: Fix ASAN build after r212401
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-15 16:23 PST by Alex Christensen
Modified: 2017-02-17 11:15 PST (History)
1 user (show)

See Also:

Attachments
Patch (25.76 KB, patch)
2017-02-15 16:23 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (6.23 KB, patch)
2017-02-15 16:44 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-02-15 16:23:16 PST 
Fix ASAN build after r212401
Comment 1 Alex Christensen 2017-02-15 16:23:36 PST 
Created attachment 301671 [details]
Patch
Comment 2 WebKit Commit Bot 2017-02-15 16:26:31 PST 
Attachment 301671 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_capture/objc/video_capture.mm:60:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_capture/objc/video_capture.mm:61:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_capture/objc/video_capture.mm:68:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_capture/objc/video_capture.mm:69:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2017-02-15 16:27:06 PST 
Comment on attachment 301671 [details]
Patch

As discussed on IRC, nowai.
Comment 4 Alex Christensen 2017-02-15 16:44:57 PST 
Created attachment 301673 [details]
Patch
Comment 5 Alex Christensen 2017-02-15 16:56:50 PST 
http://trac.webkit.org/r212413
Comment 6 Alex Christensen 2017-02-17 11:15:29 PST 
http://trac.webkit.org/r212560