LayoutTest fast/scrolling/page-cache-back-overflow-scroll-restore.html is a flaky failure

[Ryan Haddad]

LayoutTest fast/scrolling/page-cache-back-overflow-scroll-restore.html is a flaky failure

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r211985%20(10935)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fscrolling%2Fpage-cache-back-overflow-scroll-restore.html

--- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/fast/scrolling/page-cache-back-overflow-scroll-restore-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/fast/scrolling/page-cache-back-overflow-scroll-restore-actual.txt
@@ -6,7 +6,7 @@
 
 
 
-layer at (0,0) size 100x126 backgroundClip at (0,0) size 100x100 clip at (0,0) size 85x85 scrollY 41 scrollHeight 126
+layer at (0,0) size 100x126 backgroundClip at (0,0) size 100x100 clip at (0,0) size 85x85 scrollHeight 126
   RenderBlock (positioned) {DIV} at (0,0) size 100x100 [bgcolor=#CCCCCC]
     RenderBR {BR} at (0,0) size 0x18
     RenderBR {BR} at (0,18) size 0x18

[Alexey Proskuryakov]

That's a new test from r210329, we should roll out the change if it cannot be fixed quickly.

[Andreas Kling]

HmmmMMmm, I can reproduce the failure locally 100% by holding down the shift key while the test runs.

[Andreas Kling]

Okay I think I just need to fix the test to wait for a scroll event before navigating to generate the page cache entry.

[Andreas Kling]

Created attachment 301286 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 301286 [details]
Patch

Clearing flags on attachment: 301286

Committed r212199: <http://trac.webkit.org/changeset/212199>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Thank you Andreas!