Bug 168007 - Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
Summary: Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-08 11:24 PST by Jer Noble
Modified: 2017-02-08 12:43 PST (History)
3 users (show)

See Also:

Attachments
Patch (8.33 KB, patch)
2017-02-08 11:30 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2017-02-08 11:24:14 PST 
Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
Comment 1 Jer Noble 2017-02-08 11:25:22 PST 
rdar://problem/30423806
Comment 2 Jer Noble 2017-02-08 11:30:50 PST 
Created attachment 300929 [details]
Patch
Comment 3 WebKit Commit Bot 2017-02-08 12:17:38 PST 
Comment on attachment 300929 [details]
Patch

Clearing flags on attachment: 300929

Committed r211891: <http://trac.webkit.org/changeset/211891>
Comment 4 WebKit Commit Bot 2017-02-08 12:17:41 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Ryan Haddad 2017-02-08 12:30:23 PST 
This change appears to have broken the 32-bit build: https://build.webkit.org/builders/Apple%20Sierra%20Release%20%2832-bit%20Build%29/builds/3474
Comment 6 Jer Noble 2017-02-08 12:43:50 PST 
Landed 32-bit build fix in <https://trac.webkit.org/changeset/211893>