Bug 167872 - [GTK][EFL] Release unused UpdateAtlas when in memory pressure situation
Summary: [GTK][EFL] Release unused UpdateAtlas when in memory pressure situation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Miguel Gomez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-06 02:43 PST by Miguel Gomez
Modified: 2017-02-06 05:34 PST (History)
2 users (show)

See Also:


Attachments
Patch (3.91 KB, patch)
2017-02-06 02:52 PST, Miguel Gomez
no flags Details | Formatted Diff | Diff
Patch (3.91 KB, patch)
2017-02-06 03:30 PST, Miguel Gomez
magomez: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2017-02-06 02:43:50 PST
The current implementation waits 3 seconds before releasing unused UpdateAtlases, in case we can reuse them.
This is nice, but if we are in a memory pressure situation we should try to release them as soon as possible to free resources.
Comment 1 Miguel Gomez 2017-02-06 02:52:03 PST
Created attachment 300701 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-02-06 03:12:33 PST
Comment on attachment 300701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300701&action=review

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:69
> +    enum ReleaseAtlasPolicy {
> +        ReleaseInactive,
> +        ReleaseUnused
> +    };

This should also be private.
Comment 3 Miguel Gomez 2017-02-06 03:30:11 PST
Created attachment 300704 [details]
Patch
Comment 4 WebKit Commit Bot 2017-02-06 04:23:34 PST
Comment on attachment 300704 [details]
Patch

Clearing flags on attachment: 300704

Committed r211721: <http://trac.webkit.org/changeset/211721>
Comment 5 WebKit Commit Bot 2017-02-06 04:23:38 PST
All reviewed patches have been landed.  Closing bug.