[macOS] WebHTMLView has an internal retain cycle with its flagsChangedEventMonitor.

[Andreas Kling]

There is an internal retain cycle in WebHTMLView:
When initializing _private->flagsChangedEventMonitor, we pass it a block that implicitly captures the WebHTMLView.

This causes WebHTMLViews to leak, they are very visible on the leaks bot.

[Andreas Kling]

Created attachment 300093 [details]
Patch

My objective-C is not very strong so please look carefully when reviewing.

[Antti Koivisto]

Comment on attachment 300093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300093&action=review

> Source/WebKit/mac/WebView/WebHTMLView.mm:3512
> +            _private->flagsChangedEventMonitor = [NSEvent addLocalMonitorForEventsMatchingMask:NSEventMaskFlagsChanged handler:[self] (NSEvent *flagsChangedEvent) {

I think

__block WebHTMLView *weakSelf = self;

works in pre-arc world.

[Andreas Kling]

Created attachment 300095 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 300095 [details]
Patch for landing

Clearing flags on attachment: 300095

Committed r211362: <http://trac.webkit.org/changeset/211362>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.