Bug 167562 - Simple line layout: PerformanceTests/Layout/simple-line-layout-innertext.html regressed at r211108
Summary: Simple line layout: PerformanceTests/Layout/simple-line-layout-innertext.html...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-29 10:54 PST by zalan
Modified: 2017-01-29 12:22 PST (History)
8 users (show)

See Also:


Attachments
Patch (6.25 KB, patch)
2017-01-29 11:08 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (6.23 KB, patch)
2017-01-29 11:44 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-01-29 10:54:48 PST
hyphenation support.
Comment 1 zalan 2017-01-29 11:08:49 PST
Created attachment 300070 [details]
Patch
Comment 2 Antti Koivisto 2017-01-29 11:13:30 PST
Comment on attachment 300070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300070&action=review

> Source/WebCore/rendering/SimpleLineLayoutResolver.cpp:56
> +    ASSERT(run.hasHyphen && run.start < run.end);

You would be better to use separate asserts.
Comment 3 Antti Koivisto 2017-01-29 11:18:32 PST
*It
Comment 4 zalan 2017-01-29 11:44:48 PST
Created attachment 300071 [details]
Patch
Comment 5 WebKit Commit Bot 2017-01-29 12:22:30 PST
Comment on attachment 300071 [details]
Patch

Clearing flags on attachment: 300071

Committed r211353: <http://trac.webkit.org/changeset/211353>
Comment 6 WebKit Commit Bot 2017-01-29 12:22:35 PST
All reviewed patches have been landed.  Closing bug.