Bug 167472 - REGRESSION (r207483): Touch Bar: Lists and BIU Buttons Missing from Touch Bar in HTML Notes
Summary: REGRESSION (r207483): Touch Bar: Lists and BIU Buttons Missing from Touch Bar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-26 16:17 PST by Wenson Hsieh
Modified: 2017-01-27 08:38 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.00 KB, patch)
2017-01-26 16:24 PST, Wenson Hsieh 		bdakin: review+
Details | Formatted Diff | Diff
Patch for landing (1.99 KB, patch)
2017-01-26 16:30 PST, Wenson Hsieh 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (1.98 KB, patch)
2017-01-26 16:40 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-01-26 16:17:39 PST 
The touch bar does not appear in HTML notes due to a recent regression.
Comment 1 Wenson Hsieh 2017-01-26 16:20:02 PST 
<rdar://problem/30149809>
Comment 2 Wenson Hsieh 2017-01-26 16:24:03 PST 
Created attachment 299875 [details]
Patch
Comment 3 Wenson Hsieh 2017-01-26 16:30:18 PST 
Created attachment 299876 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2017-01-26 16:33:20 PST 
Comment on attachment 299876 [details]
Patch for landing

Rejecting attachment 299876 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 299876, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit/mac/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/2955072
Comment 5 Wenson Hsieh 2017-01-26 16:40:31 PST 
Created attachment 299879 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-01-26 17:02:49 PST 
Comment on attachment 299879 [details]
Patch for landing

Clearing flags on attachment: 299879

Committed r211243: <http://trac.webkit.org/changeset/211243>