Bug 167389 - WKR should not confuse Miguel Gomez with Andres Gomez
Summary: WKR should not confuse Miguel Gomez with Andres Gomez
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: PC All
: P2 Minor
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-24 15:03 PST by Michael Catanzaro
Modified: 2022-02-28 03:36 PST (History)
8 users (show)

See Also:


Attachments
Patch (3.50 KB, patch)
2017-01-24 15:06 PST, Michael Catanzaro
lforschler: review+
Details | Formatted Diff | Diff
Patch (3.63 KB, patch)
2017-01-24 15:17 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-01-24 15:03:31 PST
Andres's email is a substring of Miguel's, which is causing WKR to get very confused.

I think we might have more scripts with this problem; if anyone knows of one, please say so.
Comment 1 Michael Catanzaro 2017-01-24 15:06:35 PST
Created attachment 299636 [details]
Patch
Comment 2 Michael Catanzaro 2017-01-24 15:13:33 PST
Comment on attachment 299636 [details]
Patch

Whoops, the unit test is in the wrong place.
Comment 3 Michael Catanzaro 2017-01-24 15:17:13 PST
Created attachment 299638 [details]
Patch
Comment 4 WebKit Commit Bot 2017-01-24 16:56:27 PST
Comment on attachment 299638 [details]
Patch

Clearing flags on attachment: 299638

Committed r211123: <http://trac.webkit.org/changeset/211123>
Comment 5 WebKit Commit Bot 2017-01-24 16:56:32 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Alexey Proskuryakov 2017-01-24 23:16:04 PST
Nice!