Bug 167010 - Defer use of autoplay heuristics to clients
Summary: Defer use of autoplay heuristics to clients
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: All Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-13 10:21 PST by Matt Rajca
Modified: 2017-01-13 11:17 PST (History)
2 users (show)

See Also:

Attachments
Patch (8.85 KB, patch)
2017-01-13 10:30 PST, Matt Rajca 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2017-01-13 10:21:49 PST 
Switch the autoplay policy tristate to an on/off option since clients should run any heuristics and simply send their final decision to WebKit.
Comment 1 Matt Rajca 2017-01-13 10:30:29 PST 
Created attachment 298769 [details]
Patch
Comment 2 Sam Weinig 2017-01-13 10:33:36 PST 
Comment on attachment 298769 [details]
Patch

API test?
Comment 3 Matt Rajca 2017-01-13 10:43:50 PST 
(In reply to comment #2)
> Comment on attachment 298769 [details]
> Patch
> 
> API test?

This isn't wired up yet so it'd be hard to test, seeing how the other API tests work. I'll add tests once these flags actually affect media element (coming soon).
Comment 4 Alex Christensen 2017-01-13 10:53:19 PST 
Comment on attachment 298769 [details]
Patch

Yep, this simplifies SPI that doesn't do anything yet.  r=me
Comment 5 Sam Weinig 2017-01-13 10:55:00 PST 
Please don't add stub API in the future.
Comment 6 WebKit Commit Bot 2017-01-13 11:17:40 PST 
Comment on attachment 298769 [details]
Patch

Clearing flags on attachment: 298769

Committed r210737: <http://trac.webkit.org/changeset/210737>
Comment 7 WebKit Commit Bot 2017-01-13 11:17:45 PST 
All reviewed patches have been landed.  Closing bug.