After <http://trac.webkit.org/changeset/210503>, test results are written to a duplicated file handle on Windows. I forgot to update a couple of call sites in the original patch.
Created attachment 298458 [details] Patch
Comment on attachment 298458 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298458&action=review > Tools/DumpRenderTree/DumpRenderTree.h:51 > +#endif Should this be in TestRunner.h instead, since it seems like it's mostly used in TestRunner.cpp/TestRunnerWin.cpp?
Created attachment 298575 [details] Patch
(In reply to comment #2) > Comment on attachment 298458 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=298458&action=review > > > Tools/DumpRenderTree/DumpRenderTree.h:51 > > +#endif > > Should this be in TestRunner.h instead, since it seems like it's mostly used > in TestRunner.cpp/TestRunnerWin.cpp? Thanks for reviewing! I have updated the patch.
Comment on attachment 298575 [details] Patch Clearing flags on attachment: 298575 Committed r210628: <http://trac.webkit.org/changeset/210628>
All reviewed patches have been landed. Closing bug.