Bug 166887 - Followup fix after r210503.
Summary: Followup fix after r210503.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-10 04:58 PST by Per Arne Vollan
Modified: 2017-01-12 01:23 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.43 KB, patch)
2017-01-10 05:11 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (4.99 KB, patch)
2017-01-11 06:22 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-01-10 04:58:02 PST
After <http://trac.webkit.org/changeset/210503>, test results are written to a duplicated file handle on Windows. I forgot to update a couple of call sites in the original patch.
Comment 1 Per Arne Vollan 2017-01-10 05:11:09 PST
Created attachment 298458 [details]
Patch
Comment 2 Brent Fulgham 2017-01-10 13:54:07 PST
Comment on attachment 298458 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298458&action=review

> Tools/DumpRenderTree/DumpRenderTree.h:51
> +#endif

Should this be in TestRunner.h instead, since it seems like it's mostly used in TestRunner.cpp/TestRunnerWin.cpp?
Comment 3 Per Arne Vollan 2017-01-11 06:22:50 PST
Created attachment 298575 [details]
Patch
Comment 4 Per Arne Vollan 2017-01-11 10:00:06 PST
(In reply to comment #2)
> Comment on attachment 298458 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298458&action=review
> 
> > Tools/DumpRenderTree/DumpRenderTree.h:51
> > +#endif
> 
> Should this be in TestRunner.h instead, since it seems like it's mostly used
> in TestRunner.cpp/TestRunnerWin.cpp?

Thanks for reviewing! I have updated the patch.
Comment 5 WebKit Commit Bot 2017-01-12 01:23:49 PST
Comment on attachment 298575 [details]
Patch

Clearing flags on attachment: 298575

Committed r210628: <http://trac.webkit.org/changeset/210628>
Comment 6 WebKit Commit Bot 2017-01-12 01:23:52 PST
All reviewed patches have been landed.  Closing bug.