Bug 166235 - Update keyword completions in the inspector for the new scroll snapping CSS properties
Summary: Update keyword completions in the inspector for the new scroll snapping CSS p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-20 12:54 PST by Wenson Hsieh
Modified: 2016-12-21 10:03 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.26 KB, patch)
2016-12-20 12:55 PST, Wenson Hsieh 		joepeck: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (2.30 KB, patch)
2016-12-20 13:20 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2016-12-20 12:54:05 PST 
Replace the old -webkit-scroll-snap-* CSS value keyword completions after r210024
Comment 1 Wenson Hsieh 2016-12-20 12:55:52 PST 
Created attachment 297547 [details]
Patch
Comment 2 Joseph Pecoraro 2016-12-20 13:18:16 PST 
Comment on attachment 297547 [details]
Patch

r=me!
Comment 3 WebKit Commit Bot 2016-12-20 13:19:41 PST 
Comment on attachment 297547 [details]
Patch

Rejecting attachment 297547 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 297547, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebInspectorUI/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/2760947
Comment 4 Wenson Hsieh 2016-12-20 13:20:50 PST 
Created attachment 297550 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2016-12-20 13:58:03 PST 
Comment on attachment 297550 [details]
Patch for landing

Clearing flags on attachment: 297550

Committed r210036: <http://trac.webkit.org/changeset/210036>