WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
166235
Update keyword completions in the inspector for the new scroll snapping CSS properties
https://bugs.webkit.org/show_bug.cgi?id=166235
Summary
Update keyword completions in the inspector for the new scroll snapping CSS p...
Wenson Hsieh
Reported
2016-12-20 12:54:05 PST
Replace the old -webkit-scroll-snap-* CSS value keyword completions after
r210024
Attachments
Patch
(2.26 KB, patch)
2016-12-20 12:55 PST
,
Wenson Hsieh
joepeck
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
Patch for landing
(2.30 KB, patch)
2016-12-20 13:20 PST
,
Wenson Hsieh
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Wenson Hsieh
Comment 1
2016-12-20 12:55:52 PST
Created
attachment 297547
[details]
Patch
Joseph Pecoraro
Comment 2
2016-12-20 13:18:16 PST
Comment on
attachment 297547
[details]
Patch r=me!
WebKit Commit Bot
Comment 3
2016-12-20 13:19:41 PST
Comment on
attachment 297547
[details]
Patch Rejecting
attachment 297547
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 297547, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebInspectorUI/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://webkit-queues.webkit.org/results/2760947
Wenson Hsieh
Comment 4
2016-12-20 13:20:50 PST
Created
attachment 297550
[details]
Patch for landing
WebKit Commit Bot
Comment 5
2016-12-20 13:58:03 PST
Comment on
attachment 297550
[details]
Patch for landing Clearing flags on attachment: 297550 Committed
r210036
: <
http://trac.webkit.org/changeset/210036
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug