Bug 16597 - There are no NULL checks for strings in public api
Summary: There are no NULL checks for strings in public api
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Major
Assignee: Christian Dywan
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2007-12-24 19:14 PST by Christian Dywan
Modified: 2007-12-24 22:00 PST (History)
0 users

See Also:


Attachments
Add missing NULL checks for string parameters (3.38 KB, patch)
2007-12-24 19:21 PST, Christian Dywan
alp: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Dywan 2007-12-24 19:14:12 PST
A few functions in the public api don't check passed strings for NULL. This leads to unclear behavior or crashes.

To some extent we will want to allow NULL if it is semantically reasonable.
Comment 1 Christian Dywan 2007-12-24 19:21:45 PST
Created attachment 18099 [details]
Add missing NULL checks for string parameters

This adds the missing NULL checks.

Also webkit_web_view_load_string allows for NULL mime_type and encoding, defaulting to text/html and UTF-8 respectively.
Comment 2 Alp Toker 2007-12-24 21:59:26 PST
Comment on attachment 18099 [details]
Add missing NULL checks for string parameters

r=me (with discussed small coding style fixes)
Comment 3 Alp Toker 2007-12-24 22:00:34 PST
Landed in r28978.